[coreboot-gerrit] [L] Change in coreboot[master]: src: Move common IA-32 MSRs to <cpu/x86/msr.h>

[Elyes Haouas (Code Review)]

Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28752 )

Change subject: src: Move common IA-32 MSRs to <cpu/x86/msr.h>
......................................................................

Patch Set 13:

(3 comments)

File src/cpu/intel/model_6fx/model_6fx_init.c:

https://review.coreboot.org/c/coreboot/+/28752/comment/aac6ebf0_b89352fe 
PS2, Line 62: #define IA32_PECI_CTL		0x5a0
> This MSR is not documented, so I don't know if it is specific to 6fx or not.

Done

File src/include/cpu/x86/msr.h:

https://review.coreboot.org/c/coreboot/+/28752/comment/d97f9db1_79318543 
PS11, Line 25: #define IA32_BIOS_UPDT_TRIG		0x79
             : #define IA32_BIOS_SIGN_ID		0x8b
> sounds good to me.

Ack

File src/include/cpu/x86/msr.h:

https://review.coreboot.org/c/coreboot/+/28752/comment/99aa5b31_f2affafd 
PS2, Line 126: #endif
> Done

Done