[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init: Fix false error message on parking APs twice

[Angel Pons (Code Review)]

Attention is currently required from: Nico Huber, Johnny Lin, Stefan Reinauer, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55071 )

Change subject: cpu/x86/mp_init: Fix false error message on parking APs twice
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/55071/comment/d309362e_a4a9546c 
PS2, Line 9: With Intel TXT APs are parked before LockConfig is called.
OK, the ACM requires this:
> Other threads of the same physical processor [...] must be in wait-for-SIPI state when BSP launches the ACM.

File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/55071/comment/3b8611c4_741002ed 
PS2, Line 1056: 		printk(BIOS_DEBUG, "%s: CPUs already parked\n", __func__);
> > We know they had been, but what if they aren't anymore?
>
> What do you mean? There is no code in coreboot to wake APs twice to get them in a ap_wait_for_instruction() state.

Maybe this code will appear in the future, or maybe a blob wakes up the APs again.