[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus/variants/fleex: Update GPIOs to fix EMR

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35881 )

Change subject: mb/google/octopus/variants/fleex: Update GPIOs to fix EMR
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/fleex/gpio.c:

https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu... 
PS1, Line 29: 	PAD_NC(GPIO_138, UP_20K),
> It seems to me there is no one leveraged GPIO_138?

The PEN_PDCT_ODL is leveraged GPIO_138.

https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu... 
PS1, Line 32: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD),
> I checked the original review comment but it is still wried to me that  […]

There is an external inverter on the PEN_RESET_ODL.
Therefore,
the reset and power on sequence are both fine in the EMR function.