Attention is currently required from: Raul Rangel, Tim Wawrzynczak, Julius Werner, Yu-Ping Wu, Andrey Pronin.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58669 )
Change subject: security/vboot: Use default kernel secdata size
......................................................................
Patch Set 7:
(2 comments)
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/58669/comment/224d5c00_5a2b665b
PS4, Line 70: RETURN_ON_FAILURE(tlcl_read(KERNEL_NV_INDEX,
: ctx->secdata_kernel, size));
: ret = TPM_SUCCESS;
hrmm, now that you have the RETURN_ON_FAILURE after the block, I think you can make this `ret = tlcl […]
Done
https://review.coreboot.org/c/coreboot/+/58669/comment/f73b7da8_f0f6e970
PS4, Line 77: if (vb2api_secdata_kernel_check(ctx, &size) != VB2_SUCCESS)
You still need to check for INCOMPLETE here, and potentially do a third transaction. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22d9c0079bb1175f24ff7317d116e79aa5ba08ed
Gerrit-Change-Number: 58669
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Comment-Date: Mon, 15 Nov 2021 23:19:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment