[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add provision to skip postcar and load ramstage

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34754 )

Change subject: soc/intel/cannonlake: Add provision to skip postcar and load ramstage
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34754/4/src/soc/intel/cannonlake/ro... 
File src/soc/intel/cannonlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/34754/4/src/soc/intel/cannonlake/ro... 
PS4, Line 165: 	if (postcar_frame_init(&pcf, 0))
> Aaron, should we have comments in postcar_loader. […]

The problem is that the temporary stack is only short lived (in comparison to postcar stage using it) when RAMSTAGE_LOADS_FROM_POSTCAR is enabled because ramstage very quickly switches to its own stacks allocated in bss.