Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43093 )
Change subject: haswell: relocate `romstage_common` to northbridge
......................................................................
Patch Set 2:
(1 comment)
Patch Set 1: Code-Review+2
(1 comment)
I agree that the northbridge directory is a more appropriate location,
and that is reason enough for the change. However, it's not clear to me
from reading this commit how the change helps with refactoring later.
It's for similarity with sandybridge and because it brings the files I touch around the same place
https://review.coreboot.org/c/coreboot/+/43093/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43093/1//COMMIT_MSG@7
PS1, Line 7: northrbridge
typo: northbridge
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I643982a58c6f5370c78acef93740f27df001a06d
Gerrit-Change-Number: 43093
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jul 2020 13:41:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tristan Corrick
tristan@corrick.kiwi
Gerrit-MessageType: comment