Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34328 )
Change subject: soc/intel: Use config_of()
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/icelake/pmuti...
File src/soc/intel/icelake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/icelake/pmuti...
PS1, Line 177: PCH_DEVFN_PMC
SA_DEVFN_ROOT
I'll collect these PMC -> SA changes to that other commit so the get properly argumented in the commit message.
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/skylake/final...
File src/soc/intel/skylake/finalize.c:
https://review.coreboot.org/c/coreboot/+/34328/1/src/soc/intel/skylake/final...
PS1, Line 134: PCH_DEV_PMC
Use pcidev_path_on_root?
Yes, but out of scope.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0727a6b327410197cf32f598d1312737744386b3
Gerrit-Change-Number: 34328
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Sun, 14 Jul 2019 06:22:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment