build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34947 )
Change subject: mainboars: lenovo: add basic implementation for ts p320
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34947/1/src/mainboard/lenovo/thinks...
File src/mainboard/lenovo/thinkstation_p320/bootblock.c:
https://review.coreboot.org/c/coreboot/+/34947/1/src/mainboard/lenovo/thinks...
PS1, Line 48: static void print_reg(u8 dev, u8 reg) {
open brace '{' following function definitions go on the next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifda0144255c55f124688c133eac57d88498700d8
Gerrit-Change-Number: 34947
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 18 Aug 2019 00:47:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment