Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41907 )
Change subject: mb/emulation/qemu-q35: Control SMI related FADT entries
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41907/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41907/1//COMMIT_MSG@9
PS1, Line 9: Never advertise SMI in FADT for the emulation.
Reason?
That's the way it was done. But it may be from the days before SMI support in QEMU, need to dig into this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41907
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I170058793798648c6713de1530d89ec2ac53e39a
Gerrit-Change-Number: 41907
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Gerd Hoffmann
kraxel@redhat.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jun 2020 09:00:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment