Marx Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40255 )
Change subject: soc/intel/apollolake: Disable XHCI LFPS power management ......................................................................
Patch Set 20:
(13 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/40255/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40255/15//COMMIT_MSG@9 PS15, Line 9: managemnt
management
Done
https://review.coreboot.org/c/coreboot/+/40255/15//COMMIT_MSG@10 PS15, Line 10: bit
bits?
Done
https://review.coreboot.org/c/coreboot/+/40255/15//COMMIT_MSG@10 PS15, Line 10: device tress
the devicetree
Done
https://review.coreboot.org/c/coreboot/+/40255/15//COMMIT_MSG@11 PS15, Line 11: 0x80A4(PMCTRL_REG)
Please add a space before (.
Done
https://review.coreboot.org/c/coreboot/+/40255/19/src/mainboard/google/octop... File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/40255/19/src/mainboard/google/octop... PS19, Line 81: NULL
Dead assignment (gets overwritten on the line just below)
it's variable initialization. i think each variable has initial value is a good practice no matter it's overwritten or not.
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... PS15, Line 189: * Default is 9 meaning periodic sampling interval is 9ms
- Remove space in the beginning? […]
Done
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... PS15, Line 191: PMCTRL_REG(0x80A4 bits[7:4)]
Space and )] are switched.
Done
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... PS15, Line 192: * 0:FALSE(Default), 1:True.
Space and lowercase *default*.
Done
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... PS15, Line 102: #define CFG_XHCPMCTRL 0x80a4
Align with tabs as above.
Done
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... PS15, Line 837: config_xhci_lfps_pm
Rename to `disable_xhce_lfps_pm()`?
Done
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... PS15, Line 852: BIOS_INFO
BIOS_DEBUG?
Done
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... PS15, Line 858: }
A BIOS_INFO message would be nice to have. Something to start with: […]
Done
https://review.coreboot.org/c/coreboot/+/40255/15/src/soc/intel/apollolake/c... PS15, Line 911: */
One line.
Done