Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu, Ziang Wang.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81443?usp=email )
Change subject: soc/intel/xeon_sp: Add PD_TYPE_CLUSTER ......................................................................
Patch Set 4: Code-Review+1
(5 comments)
File src/soc/intel/xeon_sp/numa.c:
https://review.coreboot.org/c/coreboot/+/81443/comment/7c758261_44b41e4f : PS4, Line 36: /* : * Rules/assumptions: : * 1. Each processor has a processor proximity domain regardless whether : * a processor has DIMM attached to it or not. : * 2. All system memory map elements are either from processor attached memory, : * or from CXL memory. Each CXL node info entry has a corresponding entry : * in system memory map elements. : * 3. Each CXL device may have multiple HDMs (Host-managed Device Memory). Each : * HDM has one and only one CXL node info entry. Each CXL node info entry : * represents a generic initiator proximity domain. : */ Would be good to expand this comment w.r.t. clusters.
https://review.coreboot.org/c/coreboot/+/81443/comment/ff45fb3c_9178a713 : PS4, Line 58: continue; Add: `const uint8_t socket_id = hob->PlatformData.IIO_resource[socket].SocketID;`
https://review.coreboot.org/c/coreboot/+/81443/comment/29dac3fc_22d57b46 : PS4, Line 60: pds.pds[i].socket_bitmap = 1 << hob->PlatformData.IIO_resource[socket].SocketID; Replace with: `pds.pds[i].socket_bitmap = 1 << socket_id;`
https://review.coreboot.org/c/coreboot/+/81443/comment/26592dd8_350ecd44 : PS4, Line 68: pds.pds[i].socket_bitmap = 1 << hob->PlatformData.IIO_resource[socket].SocketID; Replace with: `pds.pds[i].socket_bitmap = 1 << socket_id;`
https://review.coreboot.org/c/coreboot/+/81443/comment/6e1d6c43_bff7dbce : PS4, Line 70: pds.pds[i].distances = malloc(sizeof(uint8_t) * pds.num_pds); : if (!pds.pds[i].distances) : die("%s %d out of memory.", __FILE__, __LINE__); : i++; This bit could be factored out into a helper function, but can be done in a follow-up.