Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40674 )
Change subject: arch/x86/acpi_device: Add a helper function to write PCI device
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40674/4/src/arch/x86/include/arch/a...
File src/arch/x86/include/arch/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/40674/4/src/arch/x86/include/arch/a...
PS4, Line 507: Device that is added to SSDT cannot be accessed from DSDT. So, if there are any
: * references to this PCI device required from static asl files, do not use this function and
: * instead add the device to DSDT as well
It's been a while I played with it. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I932af917d91198876fe8e90af9bb7a2531bd8960
Gerrit-Change-Number: 40674
Gerrit-PatchSet: 5
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Apr 2020 13:03:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment