Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39530 )
Change subject: soc/intel/Kconfig: Avoid specify dedicated chipset name ......................................................................
Patch Set 1:
(1 comment)
I had attempted this in past, had a review comment (below) on why order in required:
" Order might matter here, that `common/Kconfig` is sourced last is likely intentional.
Usually this is done so that the common code can provide a default and SoCs can override it (first `default` line encountered by Kconfig takes precedence)."
https://review.coreboot.org/c/coreboot/+/39530/1/src/soc/intel/Kconfig File src/soc/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/39530/1/src/soc/intel/Kconfig@a15 PS1, Line 15: source "src/soc/intel/common/Kconfig"
IIRC, it was done this way because we want SoC specific Kconfigs to be sourced before common Kconfig […]
Yes, had a similar comment here: https://review.coreboot.org/c/coreboot/+/37554 I had checked, the .config file had config changes with this implementation