EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39678 )
Change subject: mb/google/deltaur: Provide initial devicetree
......................................................................
Patch Set 5:
(3 comments)
Finally... Others are LGTM.
https://review.coreboot.org/c/coreboot/+/39678/5/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39678/5/src/mainboard/google/deltau...
PS5, Line 296: device pci 19.0 on end # I2C #4
I2C4 off.
https://review.coreboot.org/c/coreboot/+/39678/5/src/mainboard/google/deltau...
PS5, Line 314: device pci 1d.1 on end # PCIe Root Port #10
I think we can off 10-12? NVME take 4 lane.
https://review.coreboot.org/c/coreboot/+/39678/5/src/mainboard/google/deltau...
PS5, Line 333: device pci 1f.6 off end # GbE Controller
We need GBE on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I911ec08b0db3647d131113a138fb74a55612fd62
Gerrit-Change-Number: 39678
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chowski
chowski@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Mar 2020 17:05:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment