Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35444 )
Change subject: mb/gigabyte/ga-h61m-s2pv: Improve LPC decoding ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35444/1/src/mainboard/gigabyte/ga-h... File src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c:
https://review.coreboot.org/c/coreboot/+/35444/1/src/mainboard/gigabyte/ga-h... PS1, Line 32: pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x10);
Sorry, didn't mean to leave this unresolved (and it's 0x2f8 ofc.).
yeah, I think it should work fine without it, but I once had issues with overlapping decode ranges, so better safe than sorry I guess