[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/common: Move I2C functions to common code

[Vince Liu (Code Review)]

Attention is currently required from: Hung-Te Lin, Paul Menzel, Xi Chen, Yidi Lin, Yu-Ping Wu.

Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87352?usp=email )

Change subject: soc/mediatek/common: Move I2C functions to common code
......................................................................

Patch Set 5:

(1 comment)

File src/soc/mediatek/common/include/soc/i2c_v1.h:

PS1:
> I'm fine with that as well.

How about using the existing `I2C_FAST_SPEED` (i.e., 400KHz) instead of a new dummy speed? I've checked that all other legacy platforms use this speed in `mtk_i2c_bus_init(uint8_t bus)`. We could simply use `assert(speed == I2C_SPEED_FAST)` for validation without altering the existing implementation of `mtk_i2c_bus_init(uint8_t bus)`. What do you guys think?