Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38463 )
Change subject: mainboard/system76: Add System76 Lemur Pro (lemp9) ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/Kconfig:
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... PS6, Line 24: Fix failure to boot GRUB
It unfortunately is. GRUB systems do not boot correctly without the 8254 timer. Input does not work.
Ack
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... PS6, Line 20: # CPU (soc/intel/cannonlake/cpu.c)
indeed, it was a pleasant surprise when reviewing
Ack. I would have used plates instead, but I am weird :D
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... PS6, Line 98: Used by card reader
The pins are used by PCIe as you have stated
Maybe "HSIO muxed to PCIe #6" would be clearer, then?
https://review.coreboot.org/c/coreboot/+/38463/6/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/spd/Makefile.inc:
PS6:
Is there an example of a mainboard doing this?
I know of mb/hp/snb_ivb_laptops