Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )
Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede...
PS6, Line 236: Device (NVM0)
No need to expose the NVM0 device through a package in CAM1's _DSD just like how it is done for VCM?
The eeprom device will not be part of and recognized by V4L2 framework,
the vcm attribute in sensor DSD section is to expose the VCM device to v4l2 framework, while eeprom will be registered as a standard nvmem device
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19e4a4107c5bc9d96f718d654df50e2705b98c03
Gerrit-Change-Number: 41173
Gerrit-PatchSet: 6
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jun 2020 07:09:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment