Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41786 )
Change subject: soc/intel/apollolake: Reinstate APL_SKIP_SET_POWER_LIMITS
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41786/1/src/soc/intel/apollolake/ch...
File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/c/coreboot/+/41786/1/src/soc/intel/apollolake/ch...
PS1, Line 325: if (CONFIG(APL_SKIP_SET_POWER_LIMITS)) {
: printk(BIOS_INFO, "Skip the RAPL settings.\n");
: return;
: }
This is better but having it here would meen that in the case where APL_SKIP_SET_POWER_LIMITS is set […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41786
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec9f9f340d50a1212b6ef20c2c0e1b66385ae1b2
Gerrit-Change-Number: 41786
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 May 2020 15:25:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment