25 Nov
2020
25 Nov
'20
12:30 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45214 )
Change subject: trogdor/sc7180: Clarify USE_QC_BLOBS requirements ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45214/3/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/45214/3/src/mainboard/google/trogdo... PS3, Line 3: if USE_QC_BLOBS
this is not something that should be in Kconfig.name and also breaks Kconfig: […]
ugh... nvm. I had a board selecting USE_BLOBS in my local tree, leading to that o.O
--
To view, visit https://review.coreboot.org/c/coreboot/+/45214
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I973cae8026a229408a1a1817c4808b0266387ea7
Gerrit-Change-Number: 45214
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Philip Chen philipchen@chromium.org
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Nov 2020 11:30:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment