Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Arthur Heymans, Michael Niewöhner, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55224 )
Change subject: soc/intel/skylake: Auto-configure SerialIoDevMode UPD
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/55224/comment/f9544856_1c8ac450
PS1, Line 180: DERIVE_SERIALIO_CFG_FROM_DEV_STATE
It's necessary for now, but can be removed once all mainboards select it. Having it allows adapting each board in a separate commit, which is useful because some boards may have inconsistencies (between SerialIoDevMode values and device states).
Makes sense. I was suspecting the same. Thanks for confirming!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55224
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59ec760e4dcc6b64e40c6ebd402642070f1de33a
Gerrit-Change-Number: 55224
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 04 Jun 2021 13:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment