Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42077 )
Change subject: soc/intel/common/block: Enable PMC IPC driver
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42077/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/42077/6/src/soc/intel/common/block/...
PS6, Line 44: */
nit: space before the comment closing
https://review.coreboot.org/c/coreboot/+/42077/6/src/soc/intel/common/block/...
PS6, Line 610: const uintptr_t pmcbase = soc_read_pmc_base();
: return (void *)(pmcbase + pmc_reg_offset);
I think `return (soc_read_pmc_base() + pmc_reg_offset);` would be enough, the cast to `void *` is no […]
The cast is because readX / writeX functions take a pointer
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide3528975be23585ce305f6cc909767b96af200f
Gerrit-Change-Number: 42077
Gerrit-PatchSet: 6
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sat, 25 Jul 2020 00:16:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment