Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ......................................................................
Patch Set 7:
(5 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/298ee7be_ba7181cb PS7, Line 56: Signed-off-by: Michał Kopeć michal.kopec@3mdeb.com Non-standard signature: Co-authored-by:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/7066736d_5d603831 PS7, Line 57: Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Non-standard signature: Co-authored-by:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/ff08cd9d_1a617ea2 PS7, Line 58: Signed-off-by: Michael Niewöhner foss@mniewoehner.de Non-standard signature: Co-authored-by:
File src/ec/clevo/it5570e/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/2317c7dd_97ea1184 PS7, Line 119: if (dev->path.type == DEVICE_PATH_GENERIC && dev->path.generic.id == 0) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/86e52cf5_d6b3775e PS7, Line 122: else { else should follow close brace '}'