Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )
Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 14: PAD_GPI
Shouldn't this be PAD_INT?
Done
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 140: STH9324
What kernel driver is used for this? I don't see this HID in kernel v5. […]
According to https://partnerissuetracker.corp.google.com/issues/161759253#comment8 , there is no device driver for STH9324 in kernel v5.4 now. The kernel driver should be cherry-picked/upstreamed to kernel v5.4 later.