build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37833 )
Change subject: hatch: Fix FPMCU pwr/rst gpio handling for dratini/jinlon ......................................................................
Patch Set 1:
(36 comments)
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/dratini/gpio.c:
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 149: PAD_CFG_GPO(GPP_A12, 1, DEEP), /* FPMCU_RST_ODL */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 149: PAD_CFG_GPO(GPP_A12, 1, DEEP), /* FPMCU_RST_ODL */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 157: PAD_CFG_GPO(GPP_A12, 0, DEEP), /* FPMCU_RST_ODL */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 157: PAD_CFG_GPO(GPP_A12, 0, DEEP), /* FPMCU_RST_ODL */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 158: PAD_CFG_GPO(GPP_C11, 0, DEEP), /* PCH_FP_PWR_EN */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 158: PAD_CFG_GPO(GPP_C11, 0, DEEP), /* PCH_FP_PWR_EN */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 163: if (slp_typ == ACPI_S5) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 163: if (slp_typ == ACPI_S5) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 164: *num = ARRAY_SIZE(s5_sleep_gpio_table); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 164: *num = ARRAY_SIZE(s5_sleep_gpio_table); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 165: return s5_sleep_gpio_table; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 165: return s5_sleep_gpio_table; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 166: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 166: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 167: *num = ARRAY_SIZE(default_sleep_gpio_table); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 167: *num = ARRAY_SIZE(default_sleep_gpio_table); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 168: return default_sleep_gpio_table; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 168: return default_sleep_gpio_table; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/gpio.c:
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 119: PAD_CFG_GPO(GPP_A12, 1, DEEP), /* FPMCU_RST_ODL */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 119: PAD_CFG_GPO(GPP_A12, 1, DEEP), /* FPMCU_RST_ODL */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 127: PAD_CFG_GPO(GPP_A12, 0, DEEP), /* FPMCU_RST_ODL */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 127: PAD_CFG_GPO(GPP_A12, 0, DEEP), /* FPMCU_RST_ODL */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 128: PAD_CFG_GPO(GPP_C11, 0, DEEP), /* PCH_FP_PWR_EN */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 128: PAD_CFG_GPO(GPP_C11, 0, DEEP), /* PCH_FP_PWR_EN */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 133: if (slp_typ == ACPI_S5) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 133: if (slp_typ == ACPI_S5) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 134: *num = ARRAY_SIZE(s5_sleep_gpio_table); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 134: *num = ARRAY_SIZE(s5_sleep_gpio_table); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 135: return s5_sleep_gpio_table; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 135: return s5_sleep_gpio_table; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 136: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 136: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 137: *num = ARRAY_SIZE(default_sleep_gpio_table); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 137: *num = ARRAY_SIZE(default_sleep_gpio_table); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 138: return default_sleep_gpio_table; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37833/1/src/mainboard/google/hatch/... PS1, Line 138: return default_sleep_gpio_table; please, no spaces at the start of a line