[coreboot-gerrit] [S] Change in coreboot[master]: Revert "soc/mediatek/mt8188: Allow CPUfreq hardware to access MCUPM r...

[Liju-Clr Chen (Code Review)]

Attention is currently required from: Hung-Te Lin.

Liju-Clr Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69139 )

Change subject: Revert "soc/mediatek/mt8188: Allow CPUfreq hardware to access MCUPM registers"
......................................................................

Revert "soc/mediatek/mt8188: Allow CPUfreq hardware to access MCUPM registers"

This reverts commit a8172c329fe309f3b5b409c1a59a227186400dd4.

In this patch, we allow MCUPM to access secure registers and set the
domain to DOMAIN_2.

Additional attribute settings are also required when a hardware is
set to a specific domain. Otherwise, there would be violation between
hardware. Since MT8188 is in bring-up stage, we simply enable access
register permission for the DOMAIN_0 by default. So remove the wrong
setting for MCUPM, SCP and SSPM.

We will complete DEVAPC setting when the settings are confirmed.

Change-Id: I5d9809f6e84b8d10bc2e6f2ea5a442e676ad3bf9
---
M src/soc/mediatek/mt8188/devapc.c
M src/soc/mediatek/mt8188/include/soc/devapc.h
2 files changed, 22 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/69139/1

diff --git a/src/soc/mediatek/mt8188/devapc.c b/src/soc/mediatek/mt8188/devapc.c
index 260b9ff..1fe3cf8 100644
--- a/src/soc/mediatek/mt8188/devapc.c
+++ b/src/soc/mediatek/mt8188/devapc.c
@@ -1550,12 +1550,6 @@

static void infra_init(uintptr_t base)
 {
-	/* Side band */
-	SET32_BITFIELDS(getreg(base, MAS_SEC_0), MCUPM_SEC, SECURE_TRANS);
-
-	/* Master domain */
-	SET32_BITFIELDS(getreg(base, MAS_DOM_0), SCP_SSPM_DOM, DOMAIN_2, MCUPM_DOM, DOMAIN_2);
-
    /* Default APC setting */
    set_infra_ao_apc(base);
 }
diff --git a/src/soc/mediatek/mt8188/include/soc/devapc.h b/src/soc/mediatek/mt8188/include/soc/devapc.h
index d742c22..e0b0f00 100644
--- a/src/soc/mediatek/mt8188/include/soc/devapc.h
+++ b/src/soc/mediatek/mt8188/include/soc/devapc.h
@@ -17,10 +17,6 @@
    AO_APC_CON = 0x00F00,
 };

-DEFINE_BIT(MCUPM_SEC, 1)
-DEFINE_BITFIELD(MCUPM_DOM, 11, 8)
-DEFINE_BITFIELD(SCP_SSPM_DOM, 19, 16)
-
 /******************************************************************************
  * STRUCTURE DEFINITION
  ******************************************************************************/