Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47848 )
Change subject: sb/amd/agesa/hudson: define macros for GNB and IOMMU devices
......................................................................
Patch Set 1:
Patch Set 1:
the definitions look right to me, but those devices aren't in the southbridge/FCH part of the system like the rest of the devices in that file. not sure though how much we care about the separation of northbridge/southbridge in the pre-soc systems
those two should probably go into src/northbridge/amd/agesa/family15tn/pci_devs.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47848
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c17d4cb4953b28a47483f5d7db308ccc89e9281
Gerrit-Change-Number: 47848
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 22 Nov 2020 17:55:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment