Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74438 )
Change subject: ACPI: Obsolete FADT duty_offset and duty_width fields
......................................................................
Patch Set 2:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74438/comment/e33469ae_ae7f9480
PS2, Line 1692: /* Use CPU _PTC instead to provide P_CNT details. */
: fadt->duty_offset = 0;
: fadt->duty_width = 0;
not really needed after the memset in line 1663, but might still be worth having those assignments
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74438
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e84c8ccd2772c9b3d61f71b74324c8d28f4eefe
Gerrit-Change-Number: 74438
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 18 Apr 2023 17:57:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment