Attention is currently required from: Kevin Chiu, Raul Rangel, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59053 )
Change subject: mb/google/guybrush: Make GPIO_69 default for SD_AUX_RESET_L ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/guybrush/variants/guybrush/gpio.c:
https://review.coreboot.org/c/coreboot/+/59053/comment/f59318be_9d5ba4fc PS2, Line 57: /* This table is used by guybrush variant with board version >= 2. */ : static const struct soc_amd_gpio bid2_pcie_gpio_table[] = { : }; :
Nit: Empty table can be removed and NULL can be returned for bid >= 2.
Done
File src/mainboard/google/guybrush/variants/nipperkin/gpio.c:
https://review.coreboot.org/c/coreboot/+/59053/comment/4b1e6da7_32435be7 PS2, Line 51: PAD_NC(GPIO_69),
this needs to be removed since nipperkin board version 2 uses GPIO69 as SD AUX RESET too, thanks.
Done