Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Sathya Prakash M R, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54716 )
Change subject: mb/google/brya: Add firmware configuration probing for audio
......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/google/brya/variants/brya0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/54716/comment/67aa6d99_309dd32b
PS6, Line 61: printk(BIOS_INFO, "FW config is not provisioned or audio is disabled.\n");
This sounds like a warning or notice to me.
https://review.coreboot.org/c/coreboot/+/54716/comment/44a1f8d2_5a0664d5
PS6, Line 61: FW config is not provisioned or audio is disabled.
… disable all pads.
(or something similar)
https://review.coreboot.org/c/coreboot/+/54716/comment/9a1ed4a3_4b721792
PS6, Line 69: printk(BIOS_INFO, "Configure GPIOs for SoundWire audio.\n");
I’d also put the model number into the message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f159442516830f9d304d78c83f070e4fcff4a37
Gerrit-Change-Number: 54716
Gerrit-PatchSet: 6
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 27 May 2021 20:02:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment