Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45394 )
Change subject: soc/mediatek/mt8192: Add mtcmos init support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45394/1/src/soc/mediatek/mt8192/mtc...
File src/soc/mediatek/mt8192/mtcmos.c:
https://review.coreboot.org/c/coreboot/+/45394/1/src/soc/mediatek/mt8192/mtc...
PS1, Line 8: 0x05015405
is this really a mask? given you're simply writing the value directly to it, I wonder if there're better names?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45394
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7bff831eecfc2b4d315a577f6ff86befc483eab
Gerrit-Change-Number: 45394
Gerrit-PatchSet: 1
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Tue, 15 Sep 2020 05:14:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment