Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52369 )
Change subject: mb/google/dedede/metaknight: Add device list and probe daughter-board ......................................................................
mb/google/dedede/metaknight: Add device list and probe daughter-board
Metaknight has two daughter-board (DB_PORTS_1A_HDMI and DB_PORTS_LTE_HDMI), LTE and USB Type A use the same usb port,so needs to probe daughter-board to avoid USB device cannot recognize correctly.
BUG=b:184809456 TEST=build and verify USB device can recognize correctly
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Ie42d12c7ce5c7341751c3cf92b5f37b6cd4d479f Reviewed-on: https://review.coreboot.org/c/coreboot/+/52369 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Raymond Wong wongraymond@google.com Reviewed-by: Kaiyen Chang kaiyen.chang@intel.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb M src/mainboard/google/dedede/variants/metaknight/overridetree.cb 2 files changed, 23 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kaiyen Chang: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved Raymond Wong: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 012f2a7..f33995c 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -5,6 +5,7 @@ option DB_PORTS_1C_LTE 2 option DB_PORTS_1A_HDMI 3 option DB_PORTS_1C_1A 4 + option DB_PORTS_LTE_HDMI 5 end field TABLETMODE 10 option TABLETMODE_DISABLED 0 diff --git a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb index a92d969..b763cb9 100644 --- a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb +++ b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb @@ -76,7 +76,17 @@ register "reset_off_delay_ms" = "10" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)" register "enable_delay_ms" = "20" - device usb 2.3 on end + device usb 2.3 on + probe DB_PORTS DB_PORTS_LTE_HDMI + end + end + chip drivers/usb/acpi + register "desc" = ""Right Type-A Port"" + register "type" = "UPC_TYPE_A" + register "group" = "ACPI_PLD_GROUP(2, 2)" + device usb 2.3 on + probe DB_PORTS DB_PORTS_1A_HDMI + end end chip drivers/usb/acpi register "desc" = ""User Facing Camera"" @@ -91,7 +101,17 @@ chip drivers/usb/acpi register "desc" = ""LTE"" register "type" = "UPC_TYPE_INTERNAL" - device usb 3.3 on end + device usb 3.3 on + probe DB_PORTS DB_PORTS_LTE_HDMI + end + end + chip drivers/usb/acpi + register "desc" = ""Right Type-A Port"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(2, 2)" + device usb 3.3 on + probe DB_PORTS DB_PORTS_1A_HDMI + end end end end