Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee...
PS1, Line 130: 1
so all 0 works for the ports not being used. […]
Done
https://review.coreboot.org/c/coreboot/+/40245/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40245/3/src/mainboard/google/voltee...
PS3, Line 219: NF6
I set it to Native Function 6 based on this document https://docs.google. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic81adc24d10322cc305bf0fa4c38514468ea0942
Gerrit-Change-Number: 40245
Gerrit-PatchSet: 5
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Ma
magf@bitland.com.cn
Gerrit-Comment-Date: Mon, 11 May 2020 23:16:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment