30 Jan
2021
30 Jan
'21
11:05 p.m.
Attention is currently required from: Paul Menzel, Pablo Stebler, Iru Cai (vimacs). Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44750 )
Change subject: ec/hp/kbc1126: Wait a longer time after sending ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44750/comment/02a2d2c4_0880bc88 PS4, Line 9: prevents fixes
File src/ec/hp/kbc1126/ec.c:
https://review.coreboot.org/c/coreboot/+/44750/comment/61cf34dc_b5277a53 PS4, Line 27: timeout = 0x10000; The timeout is now 32 times larger, and about 655 ms. How long does it need to be?
--
To view, visit https://review.coreboot.org/c/coreboot/+/44750
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8623af75c062d6aa69d4412e0627d426c69019fb
Gerrit-Change-Number: 44750
Gerrit-PatchSet: 4
Gerrit-Owner: Pablo Stebler pablo@stebler.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Pablo Stebler pablo@stebler.xyz
Gerrit-Attention: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Comment-Date: Sat, 30 Jan 2021 23:05:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment