Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51827 )
Change subject: lint: checkpatch: Only exclude specific src/vendorcode/ subdirectories ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
Let's get this in, but I think we should also move these things out of vendorcode (after which we co […]
Where would you move them to? Coding style is not the only thing that sets vendorcode apart... for example, the Eltan stuff is following coreboot's coding style and was written specifically for coreboot (so I think it can benefit from checkpatch), but it's also implementing something that we specifically said we didn't want in coreboot proper (because it's solving the same problems that the core vboot and measured boot libraries basically already solve, and we don't want to maintain tons of different incompatible implementations for the same purpose). vendorcode is sort of a compromise for when vendors want to just quickly throw in their own stuff to support what they need without going through the full review process.
I think it's fine if you want to more officially separate the stuff that follows coreboot code style from the stuff that doesn't, but I think there's still a need for "vendorcode" that's not the same as normal coreboot code in the latter category.