Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30989 )
Change subject: intelblocks/systemagent: Add ACPI table generation hook ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/30989/6/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/#/c/30989/6/src/soc/intel/common/block/include/i... PS6, Line 5: * Copyright (C) 2019 Siemens AG
NB. I don't see how this change affects copyright. […]
Sure, agree. Can switch it back to 2017.
https://review.coreboot.org/#/c/30989/6/src/soc/intel/common/block/systemage... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/#/c/30989/6/src/soc/intel/common/block/systemage... PS6, Line 58: }
NB. with all these weak function, I wonder why the driver […]
Well, this approach just fits in current infrastructure we have around.
So your idea would be to define a second driver just on SoC level which just covers the PCI IDs of that single SoC? And then duplicate it for the SoC even if we have this driver around already which will match the given IDs?