Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42159 )
Change subject: crossgcc: Update to GCC 8.4.0 ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/42159/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42159/1//COMMIT_MSG@10 PS1, Line 10: - Backport GNAT exception handler v1 Could you please elaborate why the backport is useful, considering it wasn’t there with 8.3.0?
https://review.coreboot.org/c/coreboot/+/42159/1//COMMIT_MSG@11 PS1, Line 11: Run-time tested how?
https://review.coreboot.org/c/coreboot/+/42159/1/util/crossgcc/patches/gcc-8... File util/crossgcc/patches/gcc-8.4.0_gnat_eh.patch:
https://review.coreboot.org/c/coreboot/+/42159/1/util/crossgcc/patches/gcc-8... PS1, Line 5: rework Ada EH Machine_Occurrence deallocation Probably a separate issue, but instead of copying the `git show` output, `git format-patch` should be used instead.