Michael Büchler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44167 )
Change subject: mb/acer/g43t-am3: add Acer G43T-AM3 mainboard ......................................................................
Patch Set 8:
(2 comments)
Am I making it more complicated than necessary? Thanks for bearing with me :)
https://review.coreboot.org/c/coreboot/+/44167/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44167/8//COMMIT_MSG@7 PS8, Line 7: mb/acer/g43t-am3: add Acer G43T-AM3 mainboard Suggestion on IRC was to change the vendor from Acer to ECS because ECS did the board design and Acer labeled it.
I kept it at Acer for this moment because it didn't seem right. The change would be based on knowledge about the industry and the obvious similarites in the layout to ECS G4x models, while the board itself contains no indication that ECS made it. I feel it wants to be called Acer.
Also I couldn't get Kconfig to show this mainboard as a model for both vendors, pointing at the same folder src/mb/ecs/g43t-am3, as suggested by Angel on IRC if I understood correctly.
But I'll be happy to change it to src/mb/ecs/g43t-am3 if I get another suggestion that it would really be the right thing.
https://review.coreboot.org/c/coreboot/+/44167/8//COMMIT_MSG@11 PS8, Line 11: calls it "G45T/G43T-AM3 V:1.0". In DMI data it is additionally called Should it be G4xT-AM3 instead?