Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34356 )
Change subject: ec/google/chromeec: Pass reference of object to BBST() method
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
We're trying something new in gerrit. All comments have to be marked as resolved before a patch can be merged.
https://review.coreboot.org/c/coreboot/+/34356/1/src/ec/google/chromeec/acpi...
File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/34356/1/src/ec/google/chromeec/acpi...
PS1, Line 198: Store (Local1, Arg2)
I think it is still valid to store to a local copy of Arg2 (treating it as another local variable) b […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34356
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8e207a2990059a60d96d8e0f3ed3c16a55c50f4
Gerrit-Change-Number: 34356
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 18 Jul 2019 16:24:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment