Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38475 )
Change subject: mainboard/hatch: Fix puff DP output on cold boots ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38475/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38475/3/src/mainboard/google/hatch/... PS3, Line 27: /* TODO: This can be moved to common directory */ Let's do the refactor first, then extend for puff. It will make it easier to spot subtle differences in behavior as pointed out below.
https://review.coreboot.org/c/coreboot/+/38475/3/src/mainboard/google/hatch/... PS3, Line 56: && !gpio_get(GPIO_DP_HPD ) This subtly changes behavior w/rt the original fizz implementation by checking HPD before timing out the regular DP ready check. Are we sure we want to do that?