Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 12:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/8c1e0b93_8e9e8ba7 PS12, Line 104: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/50d42446_137c7f83 PS12, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/b27c9d69_6da459b8 PS12, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/e9acb811_b427c83a PS12, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/10196f91_39aa1784 PS12, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/fda0bc1f_62731cb8 PS12, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/461ccce8_ee5b2386 PS12, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/f170b5b1_92461b19 PS12, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/a5387cf5_87053ecc PS12, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/99e04c85_32a4c8da PS12, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/b07f520f_f360c3bc PS12, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/f6e842b6_bdc45702 PS12, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/a0857881_9a3aea25 PS12, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/e8177868_ef3895ee PS12, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120319): https://review.coreboot.org/c/coreboot/+/52662/comment/2059d503_7273a153 PS12, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('