30 Nov
2019
30 Nov
'19
4:11 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36377 )
Change subject: mb/asrock/h110m: disable CLKREQ to use onboard LAN ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36377/5/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36377/5/src/mainboard/asrock/h110m/... PS5, Line 221: register "PcieRpEnable[5]" = "1" I would be explicit and state that clock request is disabled.
# Disable CLKREQ#, onboard LAN is always present register "PcieRpClkReqSupport[5]" = "0"
--
To view, visit https://review.coreboot.org/c/coreboot/+/36377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cbce6177c89052eb50959f43903b6f8a607e77f
Gerrit-Change-Number: 36377
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 30 Nov 2019 16:11:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment