Attention is currently required from: Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71583 )
Change subject: nb/intel/haswell: Specify supported memory type ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71583/comment/18af60b5_1ad9b593 PS4, Line 12: Note: DDR4 is not supported in coreboot yet for current northbridge. It will never be. Haswell-EP and Haswell-EX would have a separate northbridge folder, so this note is inaccurate.
It'd be better to not say anything about DDR4. However, if you want to write something, how about:
Haswell "client" (as opposed to Haswell "server", e.g. Haswell-EP and Haswell-EX) only supports DDR3 and, only on ULT, LPDDR3. Given that coreboot uses a DDR3-compatible format for LPDDR3 SPDs, Haswell only needs `USE_DDR3`.
File src/northbridge/intel/haswell/Kconfig:
https://review.coreboot.org/c/coreboot/+/71583/comment/d65cb26a_c8cc2c77 PS2, Line 6: if NORTHBRIDGE_INTEL_HASWELL : : config NORTHBRIDGE_SPECIFIC_OPTIONS : def_bool y
Done
Sorry for being unclear. Could you please change this in a separate follow-up change?
Actually, we'd prefer to not introduce dummy Kconfig symbols if there's no need. If you want consistency, it would make more sense to drop `NORTHBRIDGE_SPECIFIC_OPTIONS` instead. It should be possible to do so for all Intel northbridges.