Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42073 )
Change subject: [WIP] sb,soc/amd: Allow dynamic ACPIMMIO base address ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42073/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/42073/2/src/soc/amd/common/block/in... PS2, Line 47: #else Are you thinking we would be directly assigning to the pointer objects for each mapping when running on psp?
https://review.coreboot.org/c/coreboot/+/42073/2/src/soc/amd/common/block/in... PS2, Line 83: #define ACPIMMIO_BASE(base, x) (void *)(base + ACPIMMIO_ ## x ## _BANK) Why add the 'base' here? It also doesn't appear this macro is used any more? I think adding a comment providing expectations of use would be helpful.