Attention is currently required from: Hsuan-ting Chen, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63115 )
Change subject: libpayload: Add CONFIG_LP_ELOG and its dependency
......................................................................
Patch Set 9:
(1 comment)
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63115/comment/ac2f90ad_25de9b7c
PS9, Line 51: classes-$(CONFIG_LP_ELOG) += elog
It seems overkill to create a Kconfig and a whole extra library for such a small file. […]
Rocco did that in PS3. However, in my opinion the elog utility doesn't seem to belong to libc (and any existing libs). If there are more stuff like elog in the future, do we want to add them all to libc? I wonder if we can create a separate lib `libutil` for all these small utilities. We can keep the `elog` class name for now, but I'll rename it when there are more utilities coming.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64d0fdd2a8eff1d89a1ac451d37b61787b5564e7
Gerrit-Change-Number: 63115
Gerrit-PatchSet: 9
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 01 Jun 2022 03:00:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment