Attention is currently required from: Joel Linn, Nico Huber.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors and further options
......................................................................
Patch Set 5:
(2 comments)
File src/superio/ite/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/81426/comment/c2da8221_c46de9d2 :
PS5, Line 61: config SUPERIO_ITE_ENV_CTRL_FAN_VECTOR_RANGED
does this need `depends on SUPERIO_ITE_ENV_CTRL_FAN_VECTOR` ?
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81426/comment/0682beeb_083f7907 :
PS1, Line 369: #endif
I implemented Matt's suggestion. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81426?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94
Gerrit-Change-Number: 81426
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Linn
jl_coreboot@conductive.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Joel Linn
jl_coreboot@conductive.de
Gerrit-Comment-Date: Tue, 26 Mar 2024 01:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Joel Linn
jl_coreboot@conductive.de
Gerrit-MessageType: comment
