[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Enable display on internal panel

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31517 )

Change subject: google/kukui: Enable display on internal panel
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/31517/11/src/mainboard/google/kukui/mainboar... 
File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/#/c/31517/11/src/mainboard/google/kukui/mainboar... 
PS11, Line 57: static void display_startup(void)
> why is the display init here and not in src/soc ? […]

I think this is fine and probably cleaner than the boards where we put it in soc.c (like Gru). Whether a board has a display or not is an entirely mainboard-specific thing. On most boards we still end up having to put some display stuff (like power sequencing) in mainboard.c, and then it's oddly disjoint from the display controller initialization. Having it all in one place makes more sense, I think.