[coreboot-gerrit] Change in coreboot[master]: soc/intel: Add Intel Xeon Scalable Processor support

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )

Change subject: soc/intel: Add Intel Xeon Scalable Processor support
......................................................................

Patch Set 47:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38548/46/src/soc/intel/xeon_sp/chip... 
File src/soc/intel/xeon_sp/chip.c:

https://review.coreboot.org/c/coreboot/+/38548/46/src/soc/intel/xeon_sp/chip... 
PS46, Line 432: struct iiostack_resource stack_info;
let's zero-initialize this without calling memset:

struct iiostack_resource stack_info = { 0 };

https://review.coreboot.org/c/coreboot/+/38548/46/src/soc/intel/xeon_sp/chip... 
PS46, Line 446: stack_info.sres
it looks like we are malloc()'ing stack_info.sres in get_iiostack_info() called above, and then freeing it here. It sounds like we can drop dynamic memory management here.

I think this can be simplified like this:

struct iiostack_resource {
    size_t no_of_stacks;
    STACK_RES res[MAX_IIO_STACK];
};

struct iiostack_resource stack_info = {0};
get_iiostack_info(&stack_info);
// do whatever work is needed

This way you can get rid of malloc(), free() and memset()