Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45562 )
Change subject: nb/intel/ironlake: Add more host bridge PCI IDs ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45562/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45562/2//COMMIT_MSG@18 PS2, Line 18:
Maybe mention that only devices with broken ME firmware are affected? […]
Done, literally. (IMHO, me_cleaner breaks ME firmwares)
https://review.coreboot.org/c/coreboot/+/45562/2/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/northbridge.c:
https://review.coreboot.org/c/coreboot/+/45562/2/src/northbridge/intel/ironl... PS2, Line 230: .ops = &mc_ops, : .vendor = PCI_VENDOR_ID_INTEL, : .devices = pci_device_ids,
Use either tabs or spaces for alignment?
If I use tabs, then it flies off to the right (see where the tabstops end). If I use spaces, then people complain. If I don't align it, people complain...