Attention is currently required from: Michał Żygowski, Paul Menzel, Krystian Hebel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64639 )
Change subject: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS
......................................................................
Patch Set 10:
(1 comment)
File src/drivers/generic/cbfs-uuid/cbfs-uuid.c:
https://review.coreboot.org/c/coreboot/+/64639/comment/4ecce217_14b2ab89
PS10, Line 18: obsolete
Obsolete means out of date, please use another word.
I'd replace "all obsolete characters" with "any trailing whitespace". However, looks like the code simply expects the UUID to have a predefined length and will merely truncate anything that comes after the first N bytes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf
Gerrit-Change-Number: 64639
Gerrit-PatchSet: 10
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Mon, 03 Oct 2022 13:33:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-MessageType: comment